Repository navigation
Feature A — Bind queue removals to owner-journal admissions (#307 merge-flow) - #1245
Conversation
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4223b84c09
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let reader = BufReader::new(log.take(MAX_LOG_BYTES)); | ||
| for prior in serde_json::Deserializer::from_reader(reader).into_iter::<PriorSample>() { | ||
| let prior = prior.map_err(|_| "cannot read owner shadow journal")?; |
There was a problem hiding this comment.
Validate JSONL boundaries when replaying the journal
serde_json::Deserializer::into_iter() reads a stream of JSON values, not newline-delimited records: it accepts both two adjacent objects on one line and a complete final object without a terminating newline. Consequently, admission_replay_refuses_multiple_objects_on_one_complete_line fails, as does the complete-object fragment case in admission_replay_rejects_and_open_log_preserves_interrupted_tail_bytes. Replay also accepts the malformed complete line that the former test intends to reject. Parse each newline-terminated record separately and reject an unterminated tail so replay enforces the journal's framing contract.
Useful? React with 👍 / 👎.
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Feature A · Native work board
Ports the admission evidence portion of #307 merge-flow → board landing under #1214 and #1017. T2. Based on main after #1215 and #1239.
Replay the existing owner journal to bind a verified queue removal to a prior observed admission of the same PR head and exact merge-group SHA. Record the original queue observation and the main SHA first observed with that rejection. Preserve both across repeated observations and restarts. A removal that precedes the admission or a different head or group does not match.
The existing opt-in landing shadow writes this evidence to its existing owner journal. It projects observations only. Delivery and retry receipts remain separate owner-confirmed evidence.
The integration test opens the real journal across samples, including repeated admission observations, a later main ref, an unrelated group, a stale removal after a later admission, and a replaced PR head. Formatting, whitespace checks, and isolated compilation of all oxa-work test targets passed locally. Exact-head required CI passed, including both mandatory-bwrap partitions. The journal integration test passed in shard 2 in 0.004 seconds. Those checks apply to the original head.
Removes: nothing.
Journal framing follow-up
Head
832ce7e1replays one newline-terminated JSON object at a time. The existing protected opener still preserves an interrupted tail before trimming it. The tests check a complete object without its newline, a partial object, and a complete line containing two objects. The before-fix lane reproduced both framing defects on x86_64 and ARM64. Those were the only failing tests on both jobs. Formatting, whitespace checks, and isolated compilation passed with the fix. The new head followed normal CI and review.At
832ce7e1, required CI passed. The malformed-line control passed in shard 1 and the interrupted-tail control passed in shard 2. Authenticated Codex review completed on the same head with no code findings. The PR entered the normal merge queue.